-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dowload files support #49
base: master
Are you sure you want to change the base?
Conversation
@qoomon Anything need fixed for this to be brought in? |
sorry for the late response, I'll try to review it this weekend |
const urlObject = window.URL || window.webkitURL; | ||
const objectUrl = urlObject.createObjectURL(content); | ||
|
||
const link = document.createElement('a'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move the download logic to a separate function
let objectUrl = urlObject.createObjectURL(data); | ||
|
||
let link = document.createElement('a'); | ||
link.href = objectUrl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move the download logic to a separate function
Hi, thanks for the PR.
WDYT? |
I think they're all good ideas. I'm not that familiar with Vue or Buefy so adding all these features will be difficult for me. I'll take a wack at it when I get the chance though. |
Additions