Replace log4j:WARN with reload4j:WARN #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the original `log4j:log4j` Maven artifact is still a quite common transitive dependency, an application might easily end up with both `log4j` and `reload4j`. This commit helps user distinguish the backend that is actually used.
|
The CI failures are probably unrelated to these changes. The test should use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the original
log4j:log4jMaven artifact is still a quite common transitive dependency, an application might easily end up with both Log4j 1.2 and Reload4j.The log messages used by Reload4j are identical to those generated by Log4j 1.2 and even point to the same documentation. This can confuse users that end up with multiple SLF4J backends in their runtime. I have seen multiple question on SO due to this, the most recent is Why log4j can't find the configuration file.
Changing the status logger prefix to "reload4j" and redirecting to https://reload4j.qos.ch/faq.html could save some debugging time to users.