Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angle brackets not parsed properly in link references #475

Open
ElliotFriend opened this issue Feb 6, 2023 · 0 comments
Open

Angle brackets not parsed properly in link references #475

ElliotFriend opened this issue Feb 6, 2023 · 0 comments

Comments

@ElliotFriend
Copy link
Contributor

ElliotFriend commented Feb 6, 2023 •
edited

According to the daring fireball syntax, angle brackets can optionally surround link references.

This is [an example][id] reference-style link.

[id]: <http://example.com/>  "Optional Title Here"

When using markdown-to-jsx in this way, the resulting link href was from the root domain, and included the angle brackets (something like http://my-site.com/<http://example.com/>).
ElliotFriend added a commit to ElliotFriend/markdown-to-jsx that referenced this issue Feb 7, 2023
@ElliotFriend
Parse link reference definitions surrounded by angle brackets
6380f42 
I created issue quantizor#475, and it seemed like a simple enough change,
I wanted to take a stab at solving it. I've adjusted the regex,
and added some tests to allow angle brackets to surround link
reference definitions, like this one:

```markdown
This is [an example][id] reference-style link.

[id]: <http://example.com/>  "Optional Title Here"
```

All tests are passing.

Signed-off-by: Elliot Voris <elliot@voris.me>
@ElliotFriend ElliotFriend mentioned this issue Feb 7, 2023
Merged
quantizor pushed a commit that referenced this issue Feb 10, 2023
@ElliotFriend
Parse link reference definitions surrounded by angle brackets (#476)
5bd4503 
I created issue #475, and it seemed like a simple enough change,
I wanted to take a stab at solving it. I've adjusted the regex,
and added some tests to allow angle brackets to surround link
reference definitions, like this one:

```markdown
This is [an example][id] reference-style link.

[id]: <http://example.com/>  "Optional Title Here"
```

All tests are passing.

Signed-off-by: Elliot Voris <elliot@voris.me>
Innei pushed a commit to Innei/markdown-to-jsx that referenced this issue Aug 2, 2023
@ElliotFriend @Innei
Parse link reference definitions surrounded by angle brackets (quanti…
213cc63 
…zor#476)

I created issue quantizor#475, and it seemed like a simple enough change,
I wanted to take a stab at solving it. I've adjusted the regex,
and added some tests to allow angle brackets to surround link
reference definitions, like this one:

```markdown
This is [an example][id] reference-style link.

[id]: <http://example.com/>  "Optional Title Here"
```

All tests are passing.

Signed-off-by: Elliot Voris <elliot@voris.me>
Signed-off-by: Innei <i@innei.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ElliotFriend