Parse link reference definitions surrounded by angle brackets #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I created issue quantizor#475, and it seemed like a simple enough change, I wanted to take a stab at solving it. I've adjusted the regex, and added some tests to allow angle brackets to surround link reference definitions, like this one: ```markdown This is [an example][id] reference-style link. [id]: <http://example.com/> "Optional Title Here" ``` All tests are passing. Signed-off-by: Elliot Voris <elliot@voris.me>
Innei
pushed a commit
to Innei/markdown-to-jsx
that referenced
this pull request
Aug 2, 2023
…zor#476) I created issue quantizor#475, and it seemed like a simple enough change, I wanted to take a stab at solving it. I've adjusted the regex, and added some tests to allow angle brackets to surround link reference definitions, like this one: ```markdown This is [an example][id] reference-style link. [id]: <http://example.com/> "Optional Title Here" ``` All tests are passing. Signed-off-by: Elliot Voris <elliot@voris.me> Signed-off-by: Innei <i@innei.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created issue #475, and it seemed like a simple enough change, I wanted to take a stab at solving it. I've adjusted the regex, and added some tests to allow angle brackets to surround link reference definitions, like this one:
All tests are passing. There is one CommonMark syntax feature I couldn't quite get working. Empty link definitions are supposed to be allowed, using angle brackets like so:
This should produce:
I couldn't get the regex to work quite right, so I've left that unimplemented.
Please let me know if this PR is helpful, or if there's any changes you'd like. Thanks!