fix: consecutive blockquotes blocks #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 597d41b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
quantizor
approved these changes
Mar 22, 2024
frankie567
force-pushed
the
fix/consecutive-blockquotes
branch
from
384b00a
to
370a4e5
Compare
|
Done ✨ |
Innei
pushed a commit
to Innei/markdown-to-jsx
that referenced
this pull request
Mar 28, 2024
* fix: consecutive blockquotes blocks * chore: tweak changeset and add the example from OP --------- Co-authored-by: Evan Jacobs <570070+quantizor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if we have consecutive blockquotes, they are rendered as one:
Input
Output
This is not compliant with the GFM spec which states that we should create consecutive blocks if there is a blank line between them
This PR solves that by tweaking the
BLOCKQUOTE_Rregex and adding relevant tests. Basically, we use a lookahead to match everything until we hit at least two\n.