-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Liquibase config option allowDuplicatedChangesetIdentifiers #40493
Comments
/cc @andrejpetras (liquibase), @geoand (liquibase), @gsmet (liquibase), @radcortez (config) |
Does something like |
No, this is not working. I already tried this. |
If that's the case, then unfortunately I don't think we can do much, because from what I saw from the code, Liquibase has its own way of setting configuration that we can't hook into |
I see we can set it as a system property: |
Yeah, we could do that early enough to make it work, but it's very unfortunate to have to resort to that kind of hack |
Yeah, I completely agree it's not pretty. Not sure how to structure it but these options would basically need to be added in It should be simple enough if you're willing to give it a try. Be aware though that these will be fixed at build time. Overriding the property directly at runtime might work but you would have to test it. |
I am pretty sure we can make it work for runtime properties as well. Actually I have an idea on how to improve on your proposal. |
…fiers Because Liquibase has its own configuration system that does not allow us to integrate with it, we need to configure it using setting and resetting system properties. Fixes: quarkusio#40493
#40603 is what I have in mind. I tested it manually and it seems to work, but if someone knows how to test this in a test, please feel free to update the PR. |
That sounds great. |
Add configuration option for liquibase.allowDuplicatedChangesetIdentifiers
Description
With Liquibase 4.25.1 a new config option was introduced: liquibase.allowDuplicatedChangesetIdentifiers (see https://docs.liquibase.com/parameters/allow-duplicated-changeset-identifiers.html)
This option allows that a change set is found multiple times without failing the Liquibase migration; it effectively just ignores duplicate changesets.
As of now, there is no Quarkus specific config property for this, so one needs to define it as environment variable or system property; neither is very nice to handle.
It would be great if Quarkus adds this config option to the current list of options.
Or: would it be possible to create a more generic config way so that we could define every Liquibase config property with one single Quarkus property using a map?
Thanks.
Implementation ideas
No response
The text was updated successfully, but these errors were encountered: