Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option for liquibase.allowDuplicatedChangesetIdentifiers #40603

Merged
merged 2 commits into from
May 14, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented May 13, 2024

P.S. This is draft because I don't know how to test it

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice, this approach is indeed a lot cleaner than what I had in mind.

@geoand
Copy link
Contributor Author

geoand commented May 13, 2024

I would not have thought of it had you not brought up the system property idea 😎

@geoand
Copy link
Contributor Author

geoand commented May 13, 2024

Actually, the first commit can be improved by using a Map instead of the custom type I added.

I'll update the PR tomorrow

@Sanne Sanne changed the title Add configuration option for liquibase.allowDuplicatedChangesetIdentfiiers Add configuration option for liquibase.allowDuplicatedChangesetIdentifiers May 13, 2024
@geoand geoand marked this pull request as ready for review May 14, 2024 08:05
@quarkus-bot
Copy link

quarkus-bot bot commented May 14, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit f52e66b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/grpc-hibernate

com.example.grpc.hibernate.BlockingRawTest.shouldAdd - History

  • Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at com.example.grpc.hibernate.BlockingRawTestBase.shouldAdd(BlockingRawTestBase.java:59)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)

@geoand geoand merged commit 6c34ace into quarkusio:main May 14, 2024
65 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone May 14, 2024
@geoand geoand deleted the #40493 branch May 14, 2024 13:09
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add Liquibase config option allowDuplicatedChangesetIdentifiers
2 participants