Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extension to define CLI plugins with aliases #40580

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented May 12, 2024

Currently, when an extension defines a plugin, the name is inferred by the artifact id. In some cases that can be annoying and this pull request addresses that, by optionally allowing user to specify the alias they need.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels May 12, 2024
@iocanel
Copy link
Contributor Author

iocanel commented May 12, 2024

cc @metacosm AFAIR, this is something that you mentioned that you'd like to have.

@quarkus-bot

This comment has been minimized.

@metacosm
Copy link
Contributor

Indeed, that would be useful. Thank you!

@iocanel iocanel force-pushed the cli-plug-ext-alias branch 3 times, most recently from 7bc5014 to d905697 Compare May 16, 2024 06:03
@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented May 18, 2024

@iocanel this needs a formatting fix

@quarkus-bot
Copy link

quarkus-bot bot commented May 28, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 95f1c0b.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 17 Logs Raw logs 🔍
✔️ JVM Tests - JDK 21 Logs Raw logs 🔍
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs 🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: independent-projects/tools/devtools-common 
! Skipped: core/deployment core/runtime devtools/cli and 813 more

📦 independent-projects/tools/devtools-common

io.quarkus.cli.plugin.PluginManagerUtilTest.shouldGetPluginFromAliasedLocation line 77 - History - More details - Source on GitHub

java.lang.IllegalStateException: Could not determinate name for location.
	at io.quarkus.cli.plugin.PluginManagerUtil.lambda$getName$9(PluginManagerUtil.java:95)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at io.quarkus.cli.plugin.PluginManagerUtil.getName(PluginManagerUtil.java:95)
	at io.quarkus.cli.plugin.PluginManagerUtil.fromLocation(PluginManagerUtil.java:40)
	at io.quarkus.cli.plugin.PluginManagerUtil.fromAlias(PluginManagerUtil.java:58)
	at io.quarkus.cli.plugin.PluginManagerUtilTest.shouldGetPluginFromAliasedLocation(PluginManagerUtilTest.java:77)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)

Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

⚙️ Native Tests - Messaging1

📦 integration-tests/reactive-messaging-kafka

io.quarkus.it.kafka.KafkaConnectorIT.testFruits - History

  • Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.it.kafka.KafkaConnectorTest.testFruits(KafkaConnectorTest.java:63)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)

@geoand
Copy link
Contributor

geoand commented May 29, 2024

That Windows failure looks suspicious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants