Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make parseVCSUri less brittle #40596

Merged
merged 1 commit into from
May 14, 2024
Merged

Make parseVCSUri less brittle #40596

merged 1 commit into from
May 14, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented May 13, 2024

Fixes #40369

@gsmet gsmet mentioned this pull request May 13, 2024
Closed
@quarkus-bot
Copy link

quarkus-bot bot commented May 13, 2024 •
edited by github-actions bot

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit a80a37e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet
Copy link
Member Author

gsmet commented May 14, 2024

@geoand could you have a look at this one, I'd like to have it in 3.10.1?

@gsmet gsmet merged commit 26cbf00 into quarkusio:main May 14, 2024
21 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone May 14, 2024
@adutra
Copy link
Contributor

adutra commented May 14, 2024

@gsmet sorry for the late reply: with your changes I was able to solve my issue. 👍

@gsmet gsmet modified the milestones: 3.11 - main, 3.10.1 May 14, 2024
@gsmet
Copy link
Member Author

gsmet commented May 22, 2024

Actually, we don't need to backport it to 3.8. 3.8 checks are different and safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/kubernetes kind/bugfix
Projects
None yet
Milestone
3.10.1
Development

Successfully merging this pull request may close these issues.

Kubernetes extension crashes with NPE during build
3 participants
@gsmet @adutra @geoand