Skip to content
This repository has been archived by the owner on Nov 8, 2021. It is now read-only.

fix(install): no lint errors out of the box #33

Closed
wants to merge 1 commit into from
Closed

fix(install): no lint errors out of the box #33

wants to merge 1 commit into from

Conversation

razbakov
Copy link

@razbakov razbakov commented Jul 24, 2019

Fixes #31

babel.config.js
  1:1  error  'module' is not defined  no-undef

quasar.conf.js
    4:1   error    'module' is not defined                             no-undef
    4:28  warning  'ctx' is defined but never used                     @typescript-eslint/no-unused-vars
   82:24  error    'require' is not defined                            no-undef
  110:9   error    Identifier 'background_color' is not in camel case  @typescript-eslint/camelcase
  111:9   error    Identifier 'theme_color' is not in camel case       @typescript-eslint/camelcase
  150:22  warning  'cfg' is defined but never used                     @typescript-eslint/no-unused-vars

Copy link
Contributor

@nothingismagick nothingismagick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @outofmemoryagain - can you confirm?

@outofmemoryagain
Copy link
Collaborator

outofmemoryagain commented Jul 24, 2019

I'm ok with the globals, but I'm not sure about the camel case rule change. If I would like to enforce that rule in my TS files, how to avoid evaluating those rules on those special config.js files. Should those files (*.config.js) be explicitly added to and exclude list?

We may need to do something like this disable those rules just for our js config files..
https://eslint.org/docs/user-guide/configuring#configuration-based-on-glob-patterns

@razbakov
Copy link
Author

@outofmemoryagain I could put inline comment on config files

@outofmemoryagain
Copy link
Collaborator

outofmemoryagain commented Jul 24, 2019

@razbakov That would be preferable in the short term. I would like to exclude the typescript rules from being applied in general to our known config files. There is currently an open issue for ESLint to better support of mixed projects. typescript-eslint/typescript-eslint#109

@outofmemoryagain
Copy link
Collaborator

@razbakov how about instead of disabling the rules altogether just override it for js files

  overrides: [
    {
      files: ["**/*.js"],
      rules: {
        '@typescript-eslint/camelcase': 'off',
        '@typescript-eslint/no-unused-vars': 'off'
      }
    }
  ]

@razbakov razbakov closed this by deleting the head repository Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial lint errors
3 participants