fix(app-vite): reinstall AE on "add" without prompting user, otherwis…

…e node will cache the pkg as unavailable
quasarframework · Apr 25, 2024 · d2fd727 · d2fd727 · yusufkandemir · Apr 25, 2024
1 parent 4f88967
commit d2fd727
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 21 deletions.
diff --git a/app-vite/lib/app-extension/AppExtensionInstance.js b/app-vite/lib/app-extension/AppExtensionInstance.js
@@ -191,28 +191,12 @@ export class AppExtensionInstance {
     log(`${ skipPkgInstall ? 'Invoking' : 'Installing' } "${ this.extId }" Quasar App Extension`)
     log()
 
-    // verify if already installed
-    if (skipPkgInstall === true) {
-      if (!this.isInstalled) {
-        fatal(`Tried to invoke App Extension "${ this.extId }" but its npm package is not installed`)
-      }
-    }
-    else if (this.isInstalled) {
-      const answer = await inquirer.prompt([ {
-        name: 'reinstall',
-        type: 'confirm',
-        message: 'Already installed. Reinstall?',
-        default: false
-      } ])
-
-      if (!answer.reinstall) {
-        return
-      }
-    }
-
     if (skipPkgInstall !== true) {
       await this.#installPackage()
     }
+    else if (!this.isInstalled) {
+      fatal(`Tried to invoke App Extension "${ this.extId }" but its npm package is not installed`)
+    }
 
     const prompts = await this.#getScriptPrompts()
 

diff --git a/app-vite/lib/cache/module.nodePackager.js b/app-vite/lib/cache/module.nodePackager.js
@@ -183,7 +183,7 @@ class Pnpm extends PackageManager {
   getInstallPackageParams (names, isDevDependency) {
     return [
       'add',
-      isDevDependency ? '-D' : '',
+      isDevDependency ? '--save-dev' : '',
       ...names
     ]
   }

diff --git a/app-webpack/lib/cache/module.nodePackager.js b/app-webpack/lib/cache/module.nodePackager.js
@@ -183,7 +183,7 @@ class Pnpm extends PackageManager {
   getInstallPackageParams (names, isDevDependency) {
     return [
       'add',
-      isDevDependency ? '-D' : '',
+      isDevDependency ? '--save-dev' : '',
       ...names
     ]
   }