(fix: #13154) v-ripple unhandled error #13402
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
dev
branch (orv[X]
branch)fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
With the
v-ripple
directive issue. From comments, there are 3 immediate work around:vue 3.2.31
vue ^3.2.33
, that is now the recommended. Since latest update on vue, the developer need to explicitdefineExpose({ $q })
on<script setup>
on components usingv-ripple
.v-ripple
on your components 馃槩.But I like to propose to another temporary solution:
Ripple.js:65 => const cfg = Object.assign({}, instance?.$q?.config?.ripple, modifiers, value)
.There is still the issue with
vue ^3.2.33
not injecting$q
and losingquasar.config
, that need another workaround thandefineExpose
, but when this issue go fix, the optional chaining will be still valid.