feat(sql): support usage of ALTER table SQL to convert column types #4413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: core/src/main/resources/io/questdb/bin/darwin-amd64/libquestdb.dylib core/src/main/resources/io/questdb/bin/freebsd-amd64/libquestdb.so core/src/main/resources/io/questdb/bin/linux-amd64/libquestdb.so core/src/main/resources/io/questdb/bin/windows-amd64/libquestdb.dll core/src/main/resources/io/questdb/bin/windows-amd64/questdbr.dll
glasstiger
reviewed
May 10, 2024
core/src/main/java/io/questdb/cutlass/line/tcp/TableUpdateDetails.java
Outdated
Show resolved
Hide resolved
glasstiger
reviewed
May 10, 2024
core/src/test/java/io/questdb/test/griffin/AlterTableChangeColumnTypeTest.java
Outdated
Show resolved
Hide resolved
glasstiger
previously approved these changes
May 15, 2024
…olumn-convert # Conflicts: # core/src/main/resources/io/questdb/bin/linux-aarch64/libquestdb.so # core/src/main/resources/io/questdb/bin/linux-amd64/libquestdb.so # core/src/main/resources/io/questdb/bin/windows-amd64/libquestdb.dll # core/src/main/resources/io/questdb/bin/windows-amd64/questdbr.dll
glasstiger
approved these changes
May 15, 2024
[PR Coverage check]😍 pass : 1577 / 1670 (94.43%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #257
Support of syntax
These column-type conversions are supported:
Not included (rarely used types):
The conversion SQL rewrites the column in a single transaction. WAL tables support concurrent writes without data loss while the operation is performed. This change allows ILP to send STRING-type columns (in the fields section) to SYMBOL columns.
_metadatathat is used inSELECT *queriesAlterOperationTableWriter. This will add the column of the new type, copy the data into it, drop the old column, and change the order of SELECT * columns in metadata.