chore(http): allow certain settings that are passed through Env or config to be returned in settings endpoint #4479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ant to pass through directly to settings
bluestreak01
reviewed
May 7, 2024
bluestreak01
reviewed
May 7, 2024
bluestreak01
changed the title
ngnic
commented
May 9, 2024
…ssthrough_configuration
…ssthrough_configuration
…ssthrough_configuration
bluestreak01
approved these changes
May 17, 2024
[PR Coverage check]😍 pass : 45 / 45 (100.00%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our web console relies on the settings endpoint to toggle on/off certain functionality. In some of these cases, we want to allow certain settings to be passed through QDB and returned in the settings so that the web console can consume them. This is what the addition of PublicPassthroughConfiguration is for. It can act as a container to hold configuration values that aren't consumed by QDB that are instead just passed through and returned in settings. The word public in the name of the class is intentional. It is there to signify that properties added to it are indeed meant to be public.