-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sql): fix subqueries returning a varchar column #4492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrinot
added
Bug
Incorrect or unexpected behavior
SQL
Issues or changes relating to SQL execution
Java
Improvements that update Java code
labels
May 10, 2024
there are more cases to fix |
it's ... not great. but doing this properly would require major changes. hopefully it will get simpler again once we start storing symbols as UTF8. |
ideoma
reviewed
May 15, 2024
core/src/main/java/io/questdb/griffin/engine/functions/bool/InSymbolCursorFunctionFactory.java
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/functions/bool/InSymbolCursorFunctionFactory.java
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/table/FilterOnSubQueryRecordCursorFactory.java
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/table/LatestBySubQueryRecordCursorFactory.java
Show resolved
Hide resolved
ideoma
approved these changes
May 15, 2024
@jerrinot could you rephrase PR title and add description. The existing title is very cryptic. |
jerrinot
changed the title
chore(sql): key-ed subqueries with varchar columns fixed
chore(sql): fix subqueries returning a varchar column
May 16, 2024
[PR Coverage check]😍 pass : 35 / 39 (89.74%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some SQLs with subqueries returning a varchar column were broken.
Example:
The IN operator accepts a subquery returning a varchar column and this was broken.
Implementation note:
This bug was caused by some (delegating)
RecordCursorFactories
that expected innerRecord
to implicitly castVARCHAR
toSTRING
orSYMBOL
. WhileFunction
performs such casting,Record
does not. To complicate matters further,VirtualRecord
appears to perform casting because it merely delegates to a function, which then handles the casting. This PR updates the affectedCursorRecordFactories
to explicitly convertVARCHAR
columns to UTF-16 when necessary.