fix(sql): split_part returning old data when no match is found #4493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwoolmer
added
Bug
bluestreak01
requested changes
May 12, 2024
core/src/main/java/io/questdb/griffin/engine/functions/str/SplitPartCharFunctionFactory.java
Outdated
Show resolved
Hide resolved
bluestreak01
approved these changes
May 18, 2024
[PR Coverage check]😍 pass : 52 / 74 (70.27%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4489
Previously, the function could early return in the non-matching case without clearing the sink.
The fix is to clear it at the top of the function.The fix is to split the impls so that the local sinks are cleared, and the remote sink not cleared, refactoring the original end-of-function check.