fix(sql): IN with NULLs and STRINGs sometimes may return the wrong result #4499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… being picked up by deferred list, so make sure it doesn't instead.
nwoolmer
added
Bug
puzpuzpuz
reviewed
May 14, 2024
core/src/main/java/io/questdb/griffin/engine/functions/bool/InStrFunctionFactory.java
Show resolved
Hide resolved
[PR Coverage check]😍 pass : 2 / 2 (100.00%) file detail
|
glasstiger
approved these changes
May 14, 2024
|
Thank you! 🙏 |
ideoma
pushed a commit
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4496
The
NullConstantargs were being added to the deferred symbol list. This isn't initialised untilinit().However, the result was requested early by
functionToConstant0meaning it wasn't being picked up.Fix is to stop
NullConstantbeing deferred.