fix oom. if config resendRequestChunkSize. Loading data is batch #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 19, 2024 13:30
|
Can merge that pr？ |
chrjohn
reviewed
Mar 25, 2024
| throws IOException, InvalidMessage, FieldNotFound { | ||
|
|
||
| throws IOException, FieldNotFound { | ||
| // Prevent a one-time load of data that is too large, resulting in memory OOM。 if config resendRequestChunkSize。 |
There was a problem hiding this comment.
Could you please check that you don't use strange characters in the source code, e.g. as after
resendRequestChunkSize。
There was a problem hiding this comment.
No, what I optimized was the problem of overloading at one time.
There was a problem hiding this comment.
Could you please check that you don't use strange characters in the source code, e.g. as after
resendRequestChunkSize。
Are you asking me to remove comments from the code?
|
@chrjohn oh~, you see see |
chrjohn
reviewed
Apr 2, 2024
| @@ -3145,4 +3145,47 @@ public void testSend_ShouldKeepPossDupFlagAndOrigSendingTime_GivenAllowPosDupCon | |||
| assertTrue(sentMessage.getHeader().isSetField(PossDupFlag.FIELD)); | |||
| assertTrue(sentMessage.getHeader().isSetField(OrigSendingTime.FIELD)); | |||
| } | |||
|
|
|||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
What does this test do if you roll back your changes in the Session class? To me it looks like it just tests your session builder. But to be honest I am only looking at it on my mobile not IDE, so maybe I'm missing something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #778
If the amount of data is particularly large 。
in quickfixj-initiator delete local quickfixj file。 restart quickfixj-acceptor OOM （If there is no excessive memory）
need config
Can solve this problem