Upgraded clap to v4 #3209
Merged
Upgraded clap to v4 #3209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
guilload
reviewed
Apr 24, 2023
| @@ -227,7 +227,8 @@ pub trait Handler<M>: Actor { | |||
|
|
|||
| #[async_trait::async_trait] | |||
| impl<H, M> DeferableReplyHandler<M> for H | |||
| where H: Handler<M> | |||
| where | |||
There was a problem hiding this comment.
Use make fmt to format your changes according to our code style. It requires the nightly toolchain.
quickwit/quickwit-cli/src/index.rs
Outdated
| @@ -261,14 +261,16 @@ impl IndexCliCommand { | |||
|
|
|||
| fn parse_clear_args(matches: &ArgMatches) -> anyhow::Result<Self> { | |||
There was a problem hiding this comment.
With new API, it makes more sense to pass owned ArgMatches (see remove_subcommand) so we can use the remove_one, try_remove_one function in subcommand parsers.
quickwit/quickwit-cli/src/index.rs
Outdated
| @@ -261,14 +261,16 @@ impl IndexCliCommand { | |||
|
|
|||
| fn parse_clear_args(matches: &ArgMatches) -> anyhow::Result<Self> { | |||
| let cluster_endpoint = matches | |||
| .value_of("endpoint") | |||
| .get_one::<String>("endpoint") | |||
There was a problem hiding this comment.
This would become:
.remove_one::<String>("endpoint").map(Url::from_str).expect("...")?;| .map(Url::from_str) | ||
| .expect("`endpoint` is a required arg.")?; | ||
| let index_id = matches | ||
| .value_of("index") |
There was a problem hiding this comment.
This would become:
remove_one::<String>("index").expect("...");
quickwit/quickwit-cli/src/tool.rs
Outdated
| .expect("`config` is a required arg.")?; | ||
| let target_dir = matches | ||
| .value_of("target-dir") | ||
| .get_one::<String>("target-dir") |
There was a problem hiding this comment.
You can get_one::<PathBuf> or remove_one::<PathBuf> directly.
|
I'm going to merge this PR on a feature branch and take over so we can land the upgrade before the next release. Thanks @gautamprikshit1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the proposed changes made in this PR.
Upgraded clap to v4.
Fixes #2236