Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query matching keywords in elasticsearch response. #4341

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

fmassot
Copy link
Contributor

@fmassot fmassot commented Jan 2, 2024

This PR adds the list of keywords the query should match in the elasticsearch response for use in the Grafana plugin.
I consider this PR good enough for use in Grafana even though we have the following caveats:

  • The Grafana plugin expects a list of keywords for the query, this is less accurate than a tantivy snippet returned for each document.
  • We don't use tokenizers to deduce the list of keywords. This means that a document can match, but no keyword will be highlighted in Grafana.

@fmassot fmassot force-pushed the fmassot/add-keywords-in-search-response branch from 1366f77 to dd8582e Compare January 2, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant