feat: add the tracing layer to enhance rest api metrics #4392
Conversation
|
agreed with @fmassot to adapt the axum-prometheus approach and add gauge for pending requests |
|
@fmassot could you please take a look when you have time? |
| _latency: std::time::Duration, | ||
| _span: &tracing::Span, | ||
| ) { | ||
| let labels = self.labels.lock().expect("Failed to unlock labels").clone(); |
There was a problem hiding this comment.
I was trying to extract method_and_path obtaining in a method but it didn't compile. However, the gut feeling says that it should be possible
There was a problem hiding this comment.
I have not checked, but I suspect the span stores the method and path, and hopefully, we can access those fields later to populate the labels.
There was a problem hiding this comment.
Thanks for raising this point!
I've checked by simply putting dbg!(_span); in both on_failure and on_response and seems that the structure is barely informative:
[quickwit-serve/src/metrics.rs:135] _span = Span {
name: "request",
level: Level(
Debug,
),
target: "tower_http::trace::make_span",
disabled: true,
module_path: "tower_http::trace::make_span",
line: 109,
file: "/Users/etolbakov/.cargo/index.crates.io-6f17d22bba15001f/tower-http-0.4.4/src/trace/make_span.rs",
}
| _latency: std::time::Duration, | ||
| _span: &tracing::Span, | ||
| ) { | ||
| let labels = self.labels.lock().expect("Failed to unlock labels").clone(); |
There was a problem hiding this comment.
I have not checked, but I suspect the span stores the method and path, and hopefully, we can access those fields later to populate the labels.
Co-authored-by: Adrien Guillo <adrien.guillo@gmail.com>
Co-authored-by: Adrien Guillo <adrien.guillo@gmail.com>
Description
add the tracing layer to enhance rest api metrics
How was this PR tested?
The proposed changes have been deployed locally and verified with the
/metricsendpoint. Please find the screenshot below:Related issue
#4076