Add storage metrics for opendal storage. #4752
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassot
force-pushed
the
fmassot/add-metrics-for-opendal
branch
from
556fd17
to
9a32743
Compare
Xuanwo
reviewed
Mar 18, 2024
| @@ -88,20 +88,35 @@ impl Storage for OpendalStorage { | |||
| tokio::io::copy(&mut payload_reader, &mut storage_writer).await?; | |||
| storage_writer.close().await?; | |||
|
|
|||
| // FIXME: should be payload.len() / ByteSize::mb(8)? | |||
There was a problem hiding this comment.
Yes, after buffer enabled, opendal makes sure all upload parts is buffer size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Xuanwo We need to add storage metrics for the OpenDal storage.
Note: I'm not sure how to compute correctly the number of PUT requests.
Can you take a look?