Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a concurrency limit to rest requests. #4887

Closed
wants to merge 1 commit into from

Conversation

fulmicoton
Copy link
Contributor

@fulmicoton fulmicoton commented Apr 22, 2024

This prevents the explosion of memory observed in presence of 100+ clients, sending a lot of small batches.

@fulmicoton
Copy link
Contributor Author

fulmicoton commented Apr 22, 2024

image

After on the left
Before on the right

Both with chico(rate=100kb,batch=20kb)*300

No regression on indexing throughput observed either.

@fulmicoton
Copy link
Contributor Author

I did not managed to wrangle the type system in a way that would allow a LoadShedLayer :(

@fulmicoton fulmicoton marked this pull request as draft April 23, 2024 07:00
@fulmicoton fulmicoton closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant