use JSON for concat field #4937
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSeitz
force-pushed
the
concat_json_field
branch
3 times, most recently
from
a8e0ce6
to
90a433c
Compare
fulmicoton
approved these changes
May 6, 2024
trinity-1686a
approved these changes
May 13, 2024
use JSON for concat fields instead of concatenating text fields. With quickwit-oss/tantivy#2383 we support now non-object values on the root in the JSON field. As a nice side-effect, this will make regular JSON fields more powerful. Instead only for nested types, JSON is now also useable for flat mixed-type fields. Closes: #4924
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use JSON for concat fields instead of concatenating text fields.
With quickwit-oss/tantivy#2383 we support now
non-object values on the root in the JSON field.
As a nice side-effect, this will make regular JSON fields more powerful.
Instead only for nested types, JSON is now also useable for flat mixed-type fields.
Closes: #4924