Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve search split cache docs #4951

Merged
merged 2 commits into from May 22, 2024
Merged

Improve search split cache docs #4951

merged 2 commits into from May 22, 2024
+7 −6

Conversation

rdettai
Copy link
Contributor

@rdettai rdettai commented May 7, 2024

Description

Improve the search split cache UX by:

  • being strict on the number of split in the cache instead of letting it exceed the configured limit by one
  • making the docs a bit more explicit

How was this PR tested?

Describe how you tested this PR.

@rdettai rdettai self-assigned this May 7, 2024
@guilload guilload requested a review from fulmicoton May 7, 2024 14:41
@rdettai rdettai force-pushed the search-split-cache-docs branch 3 times, most recently from 1f69f1e to 792c708 Compare May 7, 2024 15:34
@rdettai
Copy link
Contributor Author

rdettai commented May 7, 2024 •
edited

@fulmicoton Was there a strong rational behind letting max_num_splits be exceedable by 1?

fulmicoton
fulmicoton approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@fulmicoton fulmicoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for convenience but please have a look at the comment

@rdettai rdettai enabled auto-merge (squash) May 22, 2024 07:52
@rdettai rdettai merged commit ec502f0 into main May 22, 2024
4 of 5 checks passed
@rdettai rdettai deleted the search-split-cache-docs branch May 22, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulmicoton fulmicoton fulmicoton approved these changes

Assignees

@rdettai rdettai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rdettai @fulmicoton