edited cable-highspeed to cable-64k in button properties #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this also highlights that maybe something should throw an error if a profile does not exist in the given JSON file.. Once I understand the source code a bit better I might try putting in a pull request for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was trying out the live demo, I noticed the image transfer was not working (this is also documented as an issue by someone else). When I looked into it, I found the error simply to be that the profile name used for the image receiver "cable-highspeed" did not match the one for the image transmitter "cable-64k"
Looking at the profiles JSON file, it seems like "cable-highspeed" does not exist, but "cable-64k" does. Once I made the change, the image transfer worked on my local working copy of the live example.