proto: allow rustls::ClientConfig without initial suite #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, maybe we should also implement |
djc
force-pushed
the
separate-initial-suite
branch
2 times, most recently
from
72a54d1
to
2c7a656
Compare
Ralith
approved these changes
May 13, 2024
Oops, yes, I think we should have done this from the start. Luckily I don't think there's a drawback to having both... maybe slightly worse inference in rare cases. |
|
Tested locally in quincy and it seems to be working. |
djc
force-pushed
the
separate-initial-suite
branch
from
2c7a656
to
25bef85
Compare
Added this in a second commit. Also changed the first commit to actually check that the specified |
Ralith
approved these changes
May 14, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.