Update internal linting dependencies #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krinkle
reviewed
Jan 31, 2021
| @@ -79,7 +79,7 @@ async function run( args, options ) { | |||
| require( filePath ); | |||
| } catch ( e ) { | |||
| if ( e.code === "ERR_REQUIRE_ESM" && ( !nodeVint || nodeVint >= 72 ) ) { | |||
| await import( filePath ); | |||
| await import( filePath ); // eslint-disable-line node/no-unsupported-features/es-syntax | |||
There was a problem hiding this comment.
This rule sounds pretty severe, but looks like it is an upstream bug. This syntax is supported since Node 10. The actual functionality is supported (without experimental flag) since Node 12, but that is a run-time check. The syntax is safe to have (unused) on Node 10.
Disabling the rule here seems fine, since we are already covered from a syntax perspective by ESLint's built-in checks, and by the integration tests running on the various Node versions in Travis CI.
|
Confirmed locally that re-generating |
|
Thanks @bmish ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to disable a few new eslint-plugin-node violations.