Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: add type checking for assert.async #1722

Closed
wants to merge 2 commits into from
Closed

Core: add type checking for assert.async #1722

wants to merge 2 commits into from

Conversation

zixinyin
Copy link
Contributor

Added type checking for assert.async, so for an invalid input like string, the page would not hang indefinitely.

Fixes #1721

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@zixinyin
Copy link
Contributor Author

zixinyin commented Jul 25, 2023 •
edited

The CLA page is not working for me initially so I cannot sign up that. I just signed the EasyCLA above but not sure how to proceed. Please help guide this.

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@zixinyin
Update assert.js
089287b 
remove typo
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@zixinyin zixinyin closed this Jul 25, 2023
@zixinyin zixinyin deleted the type-checking-for-async branch July 25, 2023 20:17
@Krinkle
Copy link
Member

Krinkle commented Jul 26, 2023

The CLA page is not working for me initially so I cannot sign up that. I just signed the EasyCLA above but not sure how to proceed. Please help guide this.

I'm sorry about that. Where did you find the link to the (old) CLA service?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve assert.async Function to Handle Type Checking
2 participants
@zixinyin @Krinkle