Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix compatibility with sinon.useFakeTimers in IE #1738

Merged
merged 4 commits into from Feb 8, 2024

Conversation

timmywil
Copy link
Contributor

@timmywil timmywil commented Feb 7, 2024

The Promise polyfill needed to save the unmodified setImmediate function in IE to use for Promise._immediateFn

The Promise polyfill needed to save the unmodified setImmediate
function in IE to use for Promise._immediateFn
test/main/promise.js Outdated Show resolved Hide resolved
Copy link
Member

@Krinkle Krinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two inline issues commented.

@timmywil timmywil requested a review from Krinkle February 8, 2024 01:06
@Krinkle Krinkle closed this Feb 8, 2024
@Krinkle Krinkle reopened this Feb 8, 2024
@Krinkle
Copy link
Member

Krinkle commented Feb 8, 2024

Looks like GitHub got itself in some kind of broken state, not agreeing on which commit's status to look at for the merge button, thus blocking me from merging due to waiting for a status that would never come. Closing and re-opening fixed this.

@Krinkle Krinkle merged commit 0b776c1 into qunitjs:main Feb 8, 2024
10 checks passed
@timmywil timmywil deleted the sinon branch February 8, 2024 14:38
@timmywil
Copy link
Contributor Author

timmywil commented Feb 8, 2024

Thanks! If you could do a release, I can update the jQuery branch.

Dearley78

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants