Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix hanging assert.async() after assert.timeout() #1739

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

Krinkle
Copy link
Member

@Krinkle Krinkle commented Feb 8, 2024

Follows-up 163c9bc (#1642), which changed an internalRecover() to internalStart(), whereas internalStart will (correctly) not resume if there are other pauses still remaining.

Change this back to internalRecover().

Fixes #1705.

Follows-up 163c9bc (qunitjs#1642),
which changed an internalRecover() to internalStart(), whereas
internalStart will (correctly) not resume if there are other pauses
still remaining.

Change this back to internalRecover().

Fixes qunitjs#1705.
@Krinkle Krinkle merged commit 2e87e2a into qunitjs:main Feb 9, 2024
10 checks passed
@Krinkle Krinkle deleted the fix-hang branch February 9, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Test with timeout and missing assert.async() call never times out
1 participant