Skip to content

Commit

Permalink
tests: Avoid pytrace=False for now.
Browse files Browse the repository at this point in the history
Using pytest.fail with pytrace=False hides the quteprocess output, which makes
it a lot harder to debug stuff.

This is because TestReport.longrepr is suddenly a string and we can't add infos
to it - see pytest-dev/pytest#1316
  • Loading branch information
The-Compiler committed Jan 8, 2016
1 parent ff2024a commit ab79cd2
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion tests/integration/quteprocess.py
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,9 @@ def after_test(self):
if bad_msgs:
text = 'Logged unexpected errors:\n\n' + '\n'.join(
str(e) for e in bad_msgs)
pytest.fail(text, pytrace=False)
# We'd like to use pytrace=False here but don't as a WORKAROUND
# for https://github.com/pytest-dev/pytest/issues/1316
pytest.fail(text)

def send_cmd(self, command, count=None):
"""Send a command to the running qutebrowser instance."""
Expand Down

0 comments on commit ab79cd2

Please sign in to comment.