feat: author searching #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds commit searching based on the name of the author, utilising fuzzy matching. I initially thought about just adding a basic search, but quickly realise that GitHub usernames can be a pain to type, so any help getting to the search destination faster is a bonus - hence the fuzzy matching. I didn't do too much digging into the fuzzy searching library, but Fuse.JS seemed to be a sensible choice. The trade-off for performance is a complex balance of the setup, search and teardown times.
scallaway
force-pushed
the
author-searching
branch
from
5d05c86
to
a6af1c0
Compare
tommilligan
previously approved these changes
Oct 17, 2023
We were recreating the list of users that we pick for deployment on each render and, due to the way the input works, each keypress causes a render. This means that we need to memoise `developerCommits` so that it's only recreated when the relevant information changes (or on refresh). However, we _also_ need to memoise `<DeploymentUsers />` otherwise the order of the users _could_ change with each render.
|
Just re-requesting a review from you again as I've made a few more changes based on a slight issue that I discovered with re-rendering (classic React). |
tommilligan
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds commit searching based on the name of the author, utilising fuzzy matching.
I initially thought about just adding a basic search, but quickly realise that GitHub usernames can be a pain to type, so any help getting to the search destination faster is a bonus - hence the fuzzy matching.
I didn't do too much digging into the fuzzy searching library, but Fuse.JS seemed to be a sensible choice. The trade-off for performance is a complex balance of the setup, search and teardown times.