web: add filter to own commits button #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just sets up the component to make it easier to work with for the comming commits, but I did want to pull this out on its own to make it clear what code is just moved around and what is added as a result of the new feature.
Does what it says on the tin, because unfortunately MUI doesn't give that to us for free when using `<TextField />` - they do on `<Autocomplete />`, however.
I thought of a few ways about implementing this, but figured the cleanest was to just add the login data that we already have as an `endAdornment` on the `<TextField />`. In the event that we don't have `loginData` (for whatever reason), we just don't show the button - but this doesn't affect any of the existing functionality.
scallaway
changed the title
tommilligan
previously approved these changes
Oct 18, 2023
| </IconButton> | ||
| {loginData.data ? ( | ||
| <IconButton | ||
| onClick={() => setSearch(loginData.data.login)} |
There was a problem hiding this comment.
Should this (and onChange above) be useCallback'd to avoid child rerendering?
There was a problem hiding this comment.
Possibly.
However, realistically the entire component will be rerendering due to the fact that we're passing search down to it, and that will change each time the user types something.
I thought of ways around this, but figured it didn't really matter for this use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimately, this PR does what it says on the tin, but I included two other refactoring-ish commits ahead of them with other stuff that I found whilst working on this.