feat: tweak the fuzzy search to be less fuzzy #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that for the use-case of searching for names, the defaults
that come with Fuse.JS are a little bit _too_ loose. Therefore, this
tightens them up a bit by decreasing the threshold and distance as
outlined here:
https://www.fusejs.io/api/options.html#fuzzy-matching-options
This reduces them down significantly, but I think that should be better
for match on exact names when the user clicks on the appropriate button.
tommilligan
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that for the use-case of searching for names, the defaults that come with Fuse.JS are a little bit too loose. Therefore, this tightens them up a bit by decreasing the threshold and distance as outlined here:
This reduces them down significantly, but I think that should be better for match on exact names when the user clicks on the appropriate button.