fix(web): actually inform user that they can deploy #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommilligan
previously approved these changes
Nov 7, 2023
| const userIdsWithoutCommits = new Set( | ||
| usersWithoutCommits.map((user) => user.id), | ||
| ); | ||
| if (loginData.data && userIdsWithoutCommits.has(loginData.data.id)) |
There was a problem hiding this comment.
Already existing, but we should have braces around the condition blocks here. Not using braces for if statements is weird (I'm actually amazed eslint doesn't catch on this by default).
Will push a commit that fixes and adds the eslint rule
There was a problem hiding this comment.
Might be something to do with my env to be honest.
annesylvie
force-pushed
the
fix-you-can-deploy
branch
from
2ce537c
to
23417f7
Compare
tommilligan
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was checking if the logged in user's id was in a set of objects, which would of course not work. I just need to pull out the ids from the users that do not have commits.