Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(project): remove deprecated npmScope property of nx.json #468

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

carlkentor
Copy link

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

As of version 16.2.0 of NX the npmScope property is marked as deprecated, and starting from Nx 17 it will be ignored completely. This PR ensures that future scaffolds of apps/libs receives the correct scope name, a.k.a @qwik-ui/.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

As of version 16.2.0 of NX the npmScope property is marked as deprecated, and starting from Nx 17 it
will be ignored completely. This PR ensures that future scaffolds of apps/libs receives the correct
scope name, a.k.a `@qwik-ui/`.
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@carlkentor
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants