Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New-accordion #745

Merged
merged 38 commits into from
May 25, 2024
Merged

New-accordion #745

merged 38 commits into from
May 25, 2024

Conversation

thejackshelton
Copy link
Contributor

What is it?

Refactored Accordion

  • Feature / enhancement
  • Bug
  • Docs / tests
  • Other

Why is it needed?

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have add necessary docs (if needed)
  • Added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented May 18, 2024

⚠️ No Changeset found

Latest commit: 07ad8b1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
@qwik-ui/headless Minor

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thejackshelton thejackshelton marked this pull request as draft May 18, 2024 15:48
@thejackshelton thejackshelton marked this pull request as ready for review May 23, 2024 14:00
@maiieul
Copy link
Contributor

maiieul commented May 25, 2024

Ups I approved, but we need to remember to not deprecate the Accordion animated prop.. If you could do that before merging 👍

@thejackshelton
Copy link
Contributor Author

Ups I approved, but we need to remember to not deprecate the Accordion animated prop.. If you could do that before merging 👍

Yep let me do that

Copy link

pkg-pr-new bot commented May 25, 2024

Last Commit Build: 07ad8b1

@qwik-ui/headless(07ad8b1):

npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/headless@07ad8b1    

Pull Request Build: #745

@qwik-ui/headless(#745):

npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/headless@745    

@thejackshelton thejackshelton merged commit 6c14368 into qwikifiers:main May 25, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants