chore: update select controlled example #749
Conversation
- use id-s to remove the confusion of select being a value or an id of a value
|
| <Select.Label>Logged in users</Select.Label> | ||
| <Select.Trigger class="select-trigger"> | ||
| <Select.DisplayText placeholder="Select an option" /> | ||
| </Select.Trigger> | ||
| <Select.Popover class="select-popover"> | ||
| <Select.Listbox class="select-listbox"> | ||
| {users.map((user, index) => ( | ||
| <Select.Item value={index.toString()} key={user}> | ||
| <Select.ItemLabel>{user}</Select.ItemLabel> | ||
| <Select.Item value={user.id} key={user.id}> |
There was a problem hiding this comment.
@thejackshelton your suggestion to use user.charAt(0) bumped into 2 users starting with J issue.
Having id and name in an object provides an example for many use cases, maybe even the bulk of the use cases.
|
Awesome job! Yeah completely agree with a unique user id here. LGTM, merging. Side note: I'm wrapping up the new refactored accordion, but will get to the select this week. |
What is it?
Why is it needed?
Checklist:
pnpm changeand documented my changes