Fix inefficient use of buffers that reduces the potential throughput of basicPublish #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shed method to Connection that allows us to use the write buffer more efficiently by writing all the Frames of the message and *then* flushing the buffer rather than flushing each Frame. This significantly improves the performance of basicPublish for small messages where the bulk of the CPU load tends towards Syscall so with small messages we might have a Syscall per message vice per Frame.
Zerpet
reviewed
Dec 21, 2022
Signed-off-by: Aitor Pérez Cedres <acedres@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #141
Improve the performance of Channel sendOpen method by adding an sendUnflushed method to Connection that allows us to use the write buffer more efficiently by writing all the Frames of the message and then flushing the buffer rather than flushing each Frame. This significantly improves the performance of basicPublish for small messages where the bulk of the CPU load tends towards Syscall so with small messages we might have a Syscall per message vice per Frame.