Add example producer using DeferredConfirm #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
requested changes
Jan 4, 2023
There was a problem hiding this comment.
It's good to have a deferred confirmation example, but if we show how to do it this way, people will copy this code and wonder why publishing is slow.
We should re-work this to do it the "right" way in the same manner that we do for our "Tutorial 7" examples, then we can add Go to that.
lukebakken
force-pushed
the
example-deferredConfirm
branch
from
b4ecbd7
to
88e2a7b
Compare
|
@Zerpet let me know what you think |
Zerpet
commented
Jan 18, 2023
There was a problem hiding this comment.
One question regarding the select. Everything else looks good. I pushed a change to follow Go naming convention 👀
What do you think @lukebakken ?
lukebakken
force-pushed
the
example-deferredConfirm
branch
3 times, most recently
from
30b2e6b
to
e6fb345
Compare
Signed-off-by: Aitor Pérez Cedres <acedres@vmware.com> Start tracking outstanding confirms Producer example keeps a window of outstanding confirms Update example with name conventions Following Go naming conventions. Change Dial function to use DialConfig instead, since we are creating a Config struct. Signed-off-by: Aitor Pérez Cedres <acedres@vmware.com> Better naming, better way to check confirms when exiting confirm handler The producer example should be one that handles confirms Always check exit at start of confirm handler
lukebakken
force-pushed
the
example-deferredConfirm
branch
from
e6fb345
to
0764ff4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of
DeferredConfirmationmay not be trivial or clear to everybody.This example demonstrates the use case to send a message and wait for its
confirmation, before moving forward. This would probably provide suboptimal
performance, but not every user cares about having a blazing fast rabbit.