Some unit tests in connection were showing a race condition (see #31): #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itmq#31): These ones were the ones testing Open scenarios. The issue is that Open and Close, rwc.Open and rwc.Close can at the same time write on: c.allocator = newAllocator(1, c.Config.ChannelMax) connection.go line 444 and connection.go line 849 while shutdown is protected by the structure mutex m, OpenComplete() is not causing the race. While it's not clear if the library should protect this eventuality, the tests are testing the Open function, so I think the close can be put in the main thread avoiding the race and not affecting the test validity
Zerpet
requested changes
Mar 25, 2022
There was a problem hiding this comment.
The problem with this approach is that t.Fatalf() stops the execution of the function, and in that case, Close() will never be called, potentially leaving open connections behind.
I would place the Close() call in a t.Cleanup() call to ensure it is called, regardless of the result of the test.
Co-authored-by: Daniele Palaia <dpalaia@dpalaia-a02.vmware.com>
…rsion file to manage versioning (rabbitmq#54) Co-authored-by: Daniele Palaia <dpalaia@dpalaia-a02.vmware.com>
|
@Zerpet good idea put it in all TestOpen tests |
|
Superseded by #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These ones were the ones testing Open scenarios. The issue is that Open and Close, rwc.Open and rwc.Close can at the same time write on:
c.allocator = newAllocator(1, c.Config.ChannelMax)
connection.go line 444 and
connection.go line 849
while shutdown is protected by the structure mutex m, OpenComplete() is not causing the race.
While it's not clear if the library should protect this eventuality, the tests are testing the Open function, so I think the close can be put in the main thread avoiding the race and not affecting the test validity