Add build TLS config from URI #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cacertfile, certfile, keyfile, server_name_indication from https://www.rabbitmq.com/uri-query-parameters.html
|
I don't spend much time on client libraries these days. I have asked folks who are now in charge of them to have a look. |
lukebakken
requested changes
Jul 12, 2022
lukebakken
requested changes
Jul 12, 2022
michaelklishin
approved these changes
Jul 13, 2022
lukebakken
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
cacertfile,certfile,keyfile,server_name_indicationfrom https://www.rabbitmq.com/uri-query-parameters.htmlcacertfileis not provided, system CA certificates will be used.keyfileANDcertfileprovided.Config.TLSClientConfigis set, TLS parameters from URI will be ignored.