Skip to content

Commit

Permalink
Update protobuf-java to 3.19.4
Browse files Browse the repository at this point in the history
And check the groovy plugin is consistent.

Replaces akka#1560
Groovy plugin was already updated in akka#1575
  • Loading branch information
raboof committed Feb 15, 2022
1 parent 9bf2100 commit 54d5a9d
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import org.gradle.api.Project

class AkkaGrpcPluginExtension {

static final String PROTOC_VERSION = "3.19.4"
static final String PROTOC_VERSION = "3.19.4" // checked synced by VersionSyncCheckPlugin

static final String PROTOC_PLUGIN_SCALA_VERSION = "2.12"

Expand Down
4 changes: 2 additions & 2 deletions maven-plugin/src/main/maven/plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
<extraGenerators implementation="java.util.List" default-value=""/>
<protoPaths default-value="${project.basedir}/src/main/proto,${project.basedir}/src/main/protobuf">${akka-grpc.protoPaths}</protoPaths>
<outputDirectory default-value="${project.build.directory}/generated-sources">${akka-grpc.outputDirectory}</outputDirectory>
<protocVersion implementation="java.lang.String" default-value="-v3.19.3">${akka-grpc.protoc-version}</protocVersion> <!-- checked synced by VersionSyncCheckPlugin -->
<protocVersion implementation="java.lang.String" default-value="-v3.19.4">${akka-grpc.protoc-version}</protocVersion> <!-- checked synced by VersionSyncCheckPlugin -->
<includeStdTypes implementation="boolean" default-value="false" />
</configuration>
</mojo>
Expand Down Expand Up @@ -185,7 +185,7 @@
<extraGenerators implementation="java.util.List" default-value=""/>
<protoPaths default-value="src/test/proto,src/test/protobuf">${akka-grpc.protoPaths}</protoPaths>
<outputDirectory default-value="target/generated-test-sources">${akka-grpc.outputDirectory}</outputDirectory>
<protocVersion implementation="java.lang.String" default-value="-v3.19.3">${akka-grpc.protoc-version}</protocVersion> <!-- checked synced by VersionSyncCheckPlugin -->
<protocVersion implementation="java.lang.String" default-value="-v3.19.4">${akka-grpc.protoc-version}</protocVersion> <!-- checked synced by VersionSyncCheckPlugin -->
<includeStdTypes implementation="boolean" default-value="false" />
</configuration>
</mojo>
Expand Down
2 changes: 1 addition & 1 deletion project/Dependencies.scala
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ object Dependencies {
// Even referenced explicitly in the sbt-plugin's sbt-tests
// If changing this, remember to update protoc plugin version to align in
// maven-plugin/src/main/maven/plugin.xml and akka.grpc.sbt.AkkaGrpcPlugin
val googleProtobuf = "3.19.3" // checked synced by VersionSyncCheckPlugin
val googleProtobuf = "3.19.4" // checked synced by VersionSyncCheckPlugin

val scalaTest = "3.1.4"

Expand Down
7 changes: 5 additions & 2 deletions project/VersionSyncCheckPlugin.scala
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,11 @@ object VersionSyncCheckPlugin extends AutoPlugin {
googleProtobufVersionSyncCheck := versionSyncCheckImpl(
"Google Protobuf",
Dependencies.Versions.googleProtobuf,
raw"""protocVersion.*default-value="-v(\d+\.\d+\.\d+)"""".r.unanchored,
Seq(Paths.get("maven-plugin/src/main/maven/plugin.xml"))).value)
raw"""(?i)protoc_?version.*= ?"-?v?(\d+\.\d+\.\d+)"""".r.unanchored,
Seq(
Paths.get("maven-plugin/src/main/maven/plugin.xml"),
Paths.get("gradle-plugin/src/main/groovy/akka/grpc/gradle/AkkaGrpcPluginExtension.groovy"),
)).value)

def versionSyncCheckImpl(
name: String,
Expand Down

0 comments on commit 54d5a9d

Please sign in to comment.