Fix npm install on Windows throwing "Expected linebreaks to be 'LF'but found 'CRLF'"
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… but found 'CRLF'" from eslint Fix by using the [per repository .gitattributes overrides](https://help.github.com/articles/dealing-with-line-endings/#per-repository-settings) Rationale: The Windows' default is 'auto', which will result in checking out CRLF and, as a result, eslint complaining. Since eslint is being used and its [linebreak-style](http://eslint.org/docs/rules/linebreak-style) can't be dynamic to say CRLF when checking under windows, this is the only real option. Windows editors support Unix EOLs just fine, so this should really be OK. The worst that can happen is someone that didn't rebuild commits Windows EOLs in his fork, which will get caught by the eslint checks on the pull requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… from eslint
This applies the same fix as ractivejs/rcu#29
Fix by using the per repository .gitattributes overrides
Rationale: The Windows' default is 'auto', which will result in checking out CRLF and, as a result, eslint complaining.
Since eslint is being used and its linebreak-style can't be dynamic to say CRLF when checking under windows, this is the only real option.
Windows editors support Unix EOLs just fine, so this should really be OK. The worst that can happen is someone that didn't rebuild commits Windows EOLs in his fork, which will get caught by the eslint checks on the pull requests.