[Slot] Access ref from props else fallback to element.ref #2811
Conversation
chungweileong94
requested review from
benoitgrelard,
andy-hook,
vladmoroz and
lucasmotta
as code owners
|
Just chiming in to say that I had an issue with Portal when used in conjunction with |
|
Thanks for fixing this |
|
Thank you! |
|
Is there a way to fix this manually / locally until the official fix is out? The 7x 'element.ref' warnings I am getting on each page refresh are very annoying. |
|
I also had to patch
|
Ah thx, wasn’t able to find the others, will include this as well. |
|
@juliusmarminge I applied the same fix to |
|
Just a gentle reminder that this PR being merged and released is so valuable for a lot of people. Thank you. |
| const ref = useComposedRefs(presence.ref, (child as any).ref); | ||
| // Accessing the ref from props, else fallback to element.ref | ||
| // https://github.com/facebook/react/pull/28348 | ||
| const childrenRef = child.props.ref ?? (child as any).ref; |
There was a problem hiding this comment.
It's fine to access child.ref conditionally. React only warns when accessing child.ref iff a ref prop is actually passed.
Description
fix #2769
Starting from the React 18.3.0 canary, accessing the ref via
element.refwill throw a warning, andelement.refwill be removed in the future React release.Instead, we should access the ref from props. To maintain the backward compatibility, we can do
children.props.ref ?? children.ref.