Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO-2012] allow forked PRs to run Benchmark CI and receive PR comment #1704

Draft
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

duje-begonja-rdx
Copy link

Summary

Our CI job Benchmark PR add PR comment with benchmark results. It was working fine when PR originated from this repository but when PR originates from forked repo PR comment couldn't be added.
That's because of trigger which actually run workflow from forked repository and not from this one.
By adding new trigger we enable running workflow from this repository and still testing changes introduced by outside collaborator. By that we ensure that workflow has all the right permissions.

Copy link

github-actions bot commented Feb 1, 2024

Benchmark for 3a1c687

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 70.1±0.22ms 71.0±0.17ms +1.28%
costing::decode_sbor 15.9±0.03µs 15.5±0.03µs -2.52%
costing::decode_sbor_bytes 43.3±0.05µs 47.1±0.11µs +8.78%
costing::deserialize_wasm 1284.6±5.23µs 1301.3±3.65µs +1.30%
costing::instantiate_flash_loan 3.9±0.51ms 4.0±0.65ms +2.56%
costing::instantiate_radiswap 5.9±0.03ms 5.9±0.04ms 0.00%
costing::spin_loop 25.1±0.11ms 24.6±0.05ms -1.99%
costing::validate_sbor_payload 28.8±0.05µs 27.3±0.06µs -5.21%
costing::validate_sbor_payload_bytes 368.7±0.68ns 341.9±0.76ns -7.27%
costing::validate_secp256k1 82.8±0.08µs 82.7±0.26µs -0.12%
costing::validate_wasm 39.4±0.07ms 39.5±0.09ms +0.25%
decimal::add/0 8.7±0.00ns 8.7±0.01ns 0.00%
decimal::add/rust-native 10.2±0.01ns 10.2±0.01ns 0.00%
decimal::add/wasmer 132.6±0.18ns 116.0±0.73ns -12.52%
decimal::add/wasmer-call-native 479.3±2.67ns 442.3±0.82ns -7.72%
decimal::add/wasmi 721.3±1.48ns 718.4±3.73ns -0.40%
decimal::add/wasmi-call-native 5.8±0.01µs 5.8±0.01µs 0.00%
decimal::div/0 187.9±0.13ns 214.1±0.18ns +13.94%
decimal::from_string/0 158.3±0.15ns 159.6±0.15ns +0.82%
decimal::mul/0 146.9±0.31ns 174.2±0.20ns +18.58%
decimal::mul/rust-native 144.5±0.13ns 142.9±0.23ns -1.11%
decimal::mul/wasmer 1588.3±0.95ns 1561.3±2.07ns -1.70%
decimal::mul/wasmer-call-native 594.1±0.45ns 582.2±0.51ns -2.00%
decimal::mul/wasmi 51.4±0.13µs 51.4±0.10µs 0.00%
decimal::mul/wasmi-call-native 5.9±0.01µs 5.9±0.01µs 0.00%
decimal::pow/0 677.6±0.40ns 673.5±0.88ns -0.61%
decimal::pow/rust-native 661.1±0.79ns 654.4±1.28ns -1.01%
decimal::pow/wasmer 7.1±0.01µs 7.0±0.00µs -1.41%
decimal::pow/wasmer-call-native 1054.3±1.13ns 1048.7±2.60ns -0.53%
decimal::pow/wasmi 239.9±0.26µs 241.6±0.38µs +0.71%
decimal::pow/wasmi-call-native 5.7±0.01µs 5.6±0.01µs -1.75%
decimal::root/0 8.4±0.03µs 8.4±0.03µs 0.00%
decimal::sub/0 8.9±0.01ns 8.8±0.01ns -1.12%
decimal::to_string/0 461.5±0.30ns 465.4±0.49ns +0.85%
precise_decimal::add/0 9.7±0.01ns 9.9±0.01ns +2.06%
precise_decimal::add/rust-native 12.1±0.01ns 12.1±0.01ns 0.00%
precise_decimal::add/wasmer 137.1±0.39ns 119.9±0.13ns -12.55%
precise_decimal::add/wasmer-call-native 476.1±0.55ns 459.7±1.14ns -3.44%
precise_decimal::add/wasmi 887.5±4.60ns 878.1±1.67ns -1.06%
precise_decimal::add/wasmi-call-native 6.1±0.02µs 6.2±0.00µs +1.64%
precise_decimal::div/0 313.6±6.85ns 316.6±3.47ns +0.96%
precise_decimal::from_string/0 201.9±0.26ns 202.1±0.22ns +0.10%
precise_decimal::mul/0 326.3±0.45ns 332.1±0.86ns +1.78%
precise_decimal::mul/rust-native 311.5±1.05ns 315.1±1.84ns +1.16%
precise_decimal::mul/wasmer 3.6±0.00µs 3.6±0.00µs 0.00%
precise_decimal::mul/wasmer-call-native 799.1±1.42ns 793.1±3.50ns -0.75%
precise_decimal::mul/wasmi 132.1±0.27µs 131.8±0.28µs -0.23%
precise_decimal::mul/wasmi-call-native 6.6±0.01µs 6.6±0.02µs 0.00%
precise_decimal::pow/0 1853.6±5.57ns 1843.7±10.29ns -0.53%
precise_decimal::pow/rust-native 1471.7±2.91ns 1450.5±3.86ns -1.44%
precise_decimal::pow/wasmer 16.9±0.01µs 16.8±0.03µs -0.59%
precise_decimal::pow/wasmer-call-native 2.1±0.01µs 2.1±0.00µs 0.00%
precise_decimal::pow/wasmi 638.2±1.49µs 637.0±1.42µs -0.19%
precise_decimal::pow/wasmi-call-native 13.3±0.03µs 13.2±0.02µs -0.75%
precise_decimal::root/0 59.7±0.14µs 59.6±0.10µs -0.17%
precise_decimal::sub/0 9.8±0.01ns 9.9±0.01ns +1.02%
precise_decimal::to_string/0 732.1±0.99ns 731.2±1.25ns -0.12%
schema::validate_payload 374.7±1.19µs 375.0±0.53µs +0.08%
transaction::radiswap 5.9±0.03ms 5.8±0.04ms -1.69%
transaction::transfer 1899.2±3.70µs 1847.1±3.52µs -2.74%
transaction_processing::prepare 3.1±0.00ms 2.7±0.01ms -12.90%
transaction_processing::prepare_and_decompile 6.7±0.03ms 7.0±0.06ms +4.48%
transaction_processing::prepare_and_decompile_and_recompile 24.4±0.05ms 24.2±0.07ms -0.82%
transaction_validation::validate_manifest 45.7±0.16µs 45.6±0.19µs -0.22%
transaction_validation::verify_bls_2KB 1064.3±12.61µs 1067.4±13.70µs +0.29%
transaction_validation::verify_bls_32B 1068.1±13.96µs 1070.9±12.56µs +0.26%
transaction_validation::verify_ecdsa 80.6±0.09µs 80.5±0.15µs -0.12%
transaction_validation::verify_ed25519 57.5±0.09µs 57.5±0.14µs 0.00%

@duje-begonja-rdx duje-begonja-rdx changed the base branch from main to develop February 1, 2024 12:22
Copy link

github-actions bot commented Feb 1, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:3a1c687310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant