DO-2216 / Propose an automated release workflow #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docker tags |
Benchmark for f5d012cClick to view benchmark
|
iamyulong
reviewed
May 22, 2024
.github/CODEOWNERS
Outdated
There was a problem hiding this comment.
Can we remove the codeowners change for now? We have a separate task to change that for the whole code base.
| - toml_file: "./radix-transaction-scenarios/Cargo.toml" | ||
| - toml_file: "./radix-engine-monkey-tests/Cargo.toml" | ||
| - toml_file: "./radix-engine-tests/Cargo.toml" | ||
| - toml_file: "./radix-substate-store-interface/Cargo.toml" |
There was a problem hiding this comment.
I don't fully understand how matrics work, but we need to publish the crates sequentially in this order.
iamyulong
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try this out on this mock repo https://github.com/radixdlt/release-test
release/dummytester123fromdevelop.Dispatch ReleaseThis aims to implement what has been discussed here:
https://whimsical.com/scrypto-branching-release-DXmMuH7HtitoMxKNpnd3ds
This requires Github actions to be allowed to create PRs. The setting only allows this in conjuction with approving PRs. To fix this, we add a CODEOWNERS file and allow approval only from people in the CODEOWNERS file.
The update-cargo-toml-version.sh script updates the versions of all cargo.tomls mentioned in the script. In case more crates get added, this list needs to be updated or a way to discover all radix maintained crates within this repo needs to be proposed.