Scrypto compiler default options for tests #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docker tags |
Benchmark for 3e28794Click to view benchmark
|
iamyulong
reviewed
May 13, 2024
|
|
||
| env_vars.iter().for_each(|(name, value)| { | ||
| compiler_builder.env(name, EnvironmentVariableAction::Set(value.clone())); | ||
| }); | ||
|
|
||
| #[cfg(feature = "coverage")] | ||
| { | ||
| if _use_coverage { |
There was a problem hiding this comment.
Do we still need to feature flag?
There was a problem hiding this comment.
Yes, because it changes some limits to larger values in transaction executor and wasm executor. Also there was missing coverage feature in scrypto-test project.
Additionally I've fixed scrypto coverage command memory error which was caused by using coverage feature and Rustflags on 1st compilation stage (schema extract).
mstrug-rdx
force-pushed
the
refactor/test-package-compile-default-opt
branch
from
f97fe99
to
6457b8e
Compare
mstrug-rdx
commented
May 13, 2024
iamyulong
reviewed
May 14, 2024
| @@ -1218,4 +1262,36 @@ mod tests { | |||
| assert_eq!(cmd_to_string(&cmd_phase_2), | |||
| format!("cargo build --target wasm32-unknown-unknown --target-dir {} --manifest-path {} --features scrypto/log-error --features scrypto/log-warn --features scrypto/log-info --features scrypto/no-schema --profile release", default_target_path.display(), manifest_path.display())); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_command_coverage() { | |||
There was a problem hiding this comment.
Thanks for adding a coverage test as well!
iamyulong
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added
CompilerProfiletoLedgerSimulator.Details
Adding new
scrypto-compilercrate introduced divergence between defaultscrypto buildcommand compilation options and compilation options used byLedgerSimulatorandSDKinscrypto-testproject. This PR provides option for the users ofLedgerSimulatorto choose if they want to use standardscrypto buildcompilation options or faster compilation options (WASM optimizations are disabled in that case).Also refactored
PackageFactoryto use same compiler object asLedgerSimulator.Testing
Added new tests which verifies if blueprint compiled using
scrypto buildandLedgerSimulatorwith Standard compilation options are binary same. Also added other validation tests.