Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added changes to introduce darkmode feature #782

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kartik1013
Copy link

@kartik1013 kartik1013 commented Oct 26, 2023

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Enhancement
  • Documentation Update

Description

This PR change addresses the issue #742
I am storing the user preference of the theme in the localStorage so that if the user refreshes the page or visits the page at later point of time then the same theme will be considered to render the website.

QA Instructions, Screenshots, Recordings

github_profile_readme_gen_darkmode.mp4

@kartik1013
Copy link
Author

Hi @rahuldkjain ,
Did you or anyone else get a chance to review this PR?
Thanks.

@kartik1013
Copy link
Author

Hi @rahuldkjain,
Requesting you to review this PR.
Thanks.

@g-savitha
Copy link
Collaborator

g-savitha commented Feb 27, 2024

Please remove changes from package-lock.json and commit again.
Does your code support dark mode for the icons as well? Can you also show a preview of how the website looks after your changes. @kartik1013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants